Enable WasmEdge as default interpreter #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilsa
approved these changes
Jan 19, 2024
Co-authored-by: kamilsa <kamilsa16@gmail.com>
turuslan
reviewed
Jan 19, 2024
…vm/kagome into feature/default-wasmedge-interpreter
turuslan
approved these changes
Jan 19, 2024
| } else if (interpreter == RuntimeInterpreter::WasmEdge) { | ||
| return std::static_pointer_cast<CommonType>( | ||
| injector.template create<sptr<CompiledType>>()); | ||
| } |
There was a problem hiding this comment.
May add error for interpreter == Off
There was a problem hiding this comment.
I would reconsider these CLI params after we've decided whether we keep Binaryen or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Make WasmEdge (interpreter mode) the default.
Benefits
WasmEdge is possibly faster than Binaryen.