Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad proof #2001

Merged
merged 1 commit into from
Mar 6, 2024
Merged

bad proof #2001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/primitives/transaction_validity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ OUTCOME_CPP_DEFINE_CATEGORY(kagome::primitives, InvalidTransaction::Kind, e) {
return "General error to do with the transaction being outdated (e.g. "
"nonce too low)";
case E::BadProof:
return "General error to do with the transaction's proofs (e.g. "
"signature)";
return "InvalidTransaction::BadProof. General error to do with the transaction's proofs (e.g. signature). May happen if finality lags behind best block (breaks transaction mortality encoding).";
case E::AncientBirthBlock:
return "The transaction birth block is ancient";
case E::ExhaustsResources:
Expand Down
5 changes: 2 additions & 3 deletions core/runtime/wasm_edge/module_factory_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ namespace kagome::runtime::wasm_edge {
host_instance_{host_instance},
executor_{executor},
env_{std::move(env)},
code_hash_{} {
code_hash_{code_hash} {
BOOST_ASSERT(module_ != nullptr);
BOOST_ASSERT(instance_ != nullptr);
BOOST_ASSERT(host_instance_ != nullptr);
Expand Down Expand Up @@ -298,8 +298,7 @@ namespace kagome::runtime::wasm_edge {

InstanceEnvironment env = env_factory_->make(memory_provider);

register_host_api(
*env.host_api, module_.raw(), host_instance->raw());
register_host_api(*env.host_api, module_.raw(), host_instance->raw());
WasmEdge_UNWRAP(WasmEdge_ExecutorRegisterImport(
executor_->raw(), store.raw(), host_instance->raw()));

Expand Down
Loading