Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazy trace macros #2086

Merged
merged 4 commits into from
May 14, 2024
Merged

lazy trace macros #2086

merged 4 commits into from
May 14, 2024

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • use SL_TRACE macro for lazy evaluation
  • fix args trailing comma

Possible Drawbacks

turuslan added 2 commits May 13, 2024 08:47
@turuslan
fix macro
feb392c 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
reuse macro
38a0410 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from xDimon and kamilsa May 13, 2024 04:49
@turuslan turuslan changed the title fix trace macros lazy trace macros May 13, 2024
xDimon
xDimon approved these changes May 13, 2024
View reviewed changes
core/log/trace_macros.hpp Show resolved Hide resolved
core/log/trace_macros.hpp Outdated Show resolved Hide resolved
@turuslan turuslan merged commit da13723 into master May 14, 2024
11 of 12 checks passed
@turuslan turuslan deleted the fix/trace_macros branch May 14, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDimon xDimon xDimon approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @xDimon @kamilsa