Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precompile wasm #2101

Merged
merged 2 commits into from
May 21, 2024
Merged

precompile wasm #2101

merged 2 commits into from
May 21, 2024

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented May 21, 2024

Referenced issues

Description of the Change

  • --precompile-relay and --precompile-para FILE flags
  • zombienet/precompile.sh to precompile wasm before zombie tests
  • fix double compilation of genesis (missing config)
  • fix --chain-info not stopping
  • fix macos dlopen when "kagome" is started via PATH.

Possible Drawbacks

  • zombienet/precompile.sh not called on CI, don't know where

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from kamilsa and igor-egorov May 21, 2024 08:00
Copy link
Contributor

@igor-egorov igor-egorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@@ -18,6 +18,9 @@ namespace kagome::application {
/// Prints chain info
virtual int chainInfo() = 0;

/// Precompile wasm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehehe

@turuslan turuslan merged commit b231a78 into master May 21, 2024
12 of 14 checks passed
@turuslan turuslan deleted the feature/precompile-wasm branch May 21, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: precompile wasm
3 participants