Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pvf subprocess #2126

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Disable pvf subprocess #2126

merged 7 commits into from
Jun 17, 2024

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Jun 13, 2024

Referenced issues

Related to #2123

Description of the Change

Possible Drawbacks

Less secure PVF execution

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

@kamilsa kamilsa marked this pull request as ready for review June 13, 2024 11:53
@kamilsa kamilsa requested review from igor-egorov and Harrm June 13, 2024 11:53
@kamilsa kamilsa merged commit 49cad04 into master Jun 17, 2024
17 of 27 checks passed
@kamilsa kamilsa deleted the fix/remove-pvf-subprocess branch June 17, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants