Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kagome-crates dependency #2158

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Add kagome-crates dependency #2158

merged 3 commits into from
Jul 29, 2024

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Jul 23, 2024

Referenced issues

resolves #2155 #2153

Description of the Change

All rust dependencies are one dependency for Hunter, hence it doesn't mix up Rust libraries built with different Rust toolchains.

Possible Drawbacks

If we need to reuse these rust wrappers in other projects or control their versions more fine-grained from kagome, we're gonna need to do a little refactoring on kagome-crates.

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. No

@Harrm Harrm marked this pull request as ready for review July 29, 2024 08:46
@Harrm Harrm requested review from igor-egorov and xDimon July 29, 2024 08:46
@Harrm Harrm merged commit 6a049ea into master Jul 29, 2024
12 of 14 checks passed
@Harrm Harrm deleted the feature/kagome-crates branch July 29, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crust slice::from_raw_parts null
3 participants