only pad order increment id with zeros if it is numeric #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $orderIncrementId = $this->getOrder()->getRealOrderId(); | ||
| if ( ! is_numeric( $orderIncrementId )) | ||
| { | ||
| return $orderIncrementId; |
There was a problem hiding this comment.
Can we please use substring with length of 10 (preferably from the end of the string) so that we don't exceed the max length of this parameter.
There was a problem hiding this comment.
Sure, this can be done. But be aware that in magento the increment id is not limited to a length of 10 but rather could grow up to 50 chars in length (see eav_entity_store table).
Also, in the current implementation sprintf( '%010d', $this->getOrder()->getRealOrderId() ); the length can already exceed 10. That statement will insert 0's until the string is exactly 10 chars in length. If it is longer than 10 chars the string won't be modified, though, resulting in problems already now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/wirecard/magento-wcp/issues/33