Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(downloader): stream option was not propagated to get args #550

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Sep 4, 2024

No description provided.

@github-actions github-actions bot added the bug Something isn't working label Sep 4, 2024
Copy link

sonarcloud bot commented Sep 4, 2024

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.55%. Comparing base (19a64fa) to head (59918f2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files          47       47           
  Lines        3124     3124           
  Branches      669      669           
=======================================
  Hits         2204     2204           
  Misses        726      726           
  Partials      194      194           
Flag Coverage Δ
unittests 69.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
qgis_deployment_toolbelt/utils/file_downloader.py 72.13% <ø> (ø)

@Guts Guts merged commit 58ba890 into main Sep 4, 2024
25 checks passed
@Guts Guts deleted the fix/use-stream-option branch September 4, 2024 09:17
@Guts Guts added this to the 0.35.2 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants