feat(plugin download): add application/x-zip-compressed for header Accept #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=======================================
Coverage 70.35% 70.35%
=======================================
Files 47 47
Lines 3188 3188
Branches 558 558
=======================================
Hits 2243 2243
Misses 747 747
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Guts
requested changes
Nov 29, 2024
Guts
approved these changes
Nov 29, 2024
…for content_type Co-authored-by: Julien <dev@ingeoveritas.com> Signed-off-by: jmkerloch <53606373+jmkerloch@users.noreply.github.com>
jmkerloch
force-pushed
the
feat/additionnal_zip_content_type
branch
from
923daa6 to
49fbc32
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some server might not consider plugin .zip as
application/zipbutapplication/x-zip-compressed.In this case, the server doesn't return the plugin .zip but an error page.
In this PR we add
application/x-zip-compressedto the headerAcceptto fix this issue.