Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QLR sharing file feature #219

Merged
merged 14 commits into from
Jan 3, 2022
Merged

QLR sharing file feature #219

merged 14 commits into from
Jan 3, 2022

Conversation

sumandari
Copy link
Collaborator

@sumandari sumandari commented Nov 12, 2021

Please see #212

  • CRUD
  • validation
  • parse url dataresource from .qlr
  • parse provider from .qlr
  • find out the license applied for the uploaded .qlr : free text license
  • add unit test for validation
  • add unit test for view
  • create license.txt file from license field in model
  • update download zipfile to include custom license.txt created

@sumandari
Copy link
Collaborator Author

image

@sumandari sumandari self-assigned this Nov 12, 2021
@sumandari sumandari marked this pull request as draft November 12, 2021 10:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #219 (a313222) into master (4f9990d) will increase coverage by 0.25%.
The diff coverage is 40.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   37.27%   37.53%   +0.25%     
==========================================
  Files          77       83       +6     
  Lines        3364     3634     +270     
==========================================
+ Hits         1254     1364     +110     
- Misses       2110     2270     +160     
Impacted Files Coverage Δ
qgis-app/settings_docker.py 100.00% <ø> (ø)
qgis-app/layerdefinitions/file_handler.py 21.05% <21.05%> (ø)
qgis-app/layerdefinitions/tests/test_views.py 27.90% <27.90%> (ø)
qgis-app/base/views/processing_view.py 31.09% <40.00%> (+0.32%) ⬆️
...is-app/layerdefinitions/tests/test_file_handler.py 42.85% <42.85%> (ø)
qgis-app/layerdefinitions/models.py 86.36% <86.36%> (ø)
qgis-app/layerdefinitions/admin.py 100.00% <100.00%> (ø)
...is-app/layerdefinitions/migrations/0001_initial.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f9990d...a313222. Read the comment docs.

@sumandari
Copy link
Collaborator Author

Review page:

image

Detail page

image

@sumandari
Copy link
Collaborator Author

Update menu and tiltle (#220), add url_metadata field and update license to not use cc0 rather the License of the resource itself
image

License from downloaded file is generated from license field value.
image

@sumandari sumandari marked this pull request as ready for review November 30, 2021 02:31
@timlinux
Copy link
Member

LGTM thanks!

@sumandari sumandari merged commit da81002 into qgis:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants