Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Action - Review the CI action about some python flake #227

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

Gustry
Copy link
Contributor

@Gustry Gustry commented Dec 20, 2021

Somehow, the flake8 check on the CI was not really checking the code.
To have flake8 happy on my local, I had to disable a few checks written in the file above.

The CI is happy with this.

Let's disable some of them step by step

@Gustry
Copy link
Contributor Author

Gustry commented Jan 8, 2022

@dimasciput and @sumandari Can you have a look to this PR ? Thanks

@sumandari
Copy link
Collaborator

Hi, Thanks @Gustry!
apologize for the delay, I was asking you a question about the change in setup.cfg file why there are many in the ignored list since on my local I got them checked (flake8 --version
3.7.9 (mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.1) CPython 3.8.10 on Linux).
But now I saw the comment on the line, and it looks good to me

qgis-app/*/migrations/,
qgis-app/plugins/tests/HelloWorld/,

ignore =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gustry would you please elaborate why many of them are ignored?

@sumandari
Copy link
Collaborator

sumandari commented Jan 10, 2022

Thanks again @Gustry for your work. I learned new things from your changes, I will merge it for now.

@sumandari sumandari merged commit 3c12f2c into qgis:master Jan 10, 2022
@Gustry
Copy link
Contributor Author

Gustry commented Jan 10, 2022

@sumandari Maybe before the path was not well configured ?
I got all these python warnings/errors when running flake8 on my local.
If I uncomment one of them, I will have it in the error list.

@sumandari
Copy link
Collaborator

um, I'm not sure about this 😅. I didn't see any error on my local. But this changes also fine on my local. So I don't think there will be any further issue.

@sumandari Maybe before the path was not well configured ?

@Gustry Gustry deleted the flake branch June 12, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants