Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed comment placeholder text #230

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

sumandari
Copy link
Collaborator

Please see: #229

3D Model Review (1st review)

image


QGIS Layer Definition File Review (2nd review)

image

@sumandari
Copy link
Collaborator Author

I will add the unit test

@sumandari sumandari marked this pull request as draft January 4, 2022 03:27
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #230 (03ff279) into master (9debebd) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   37.55%   37.58%   +0.03%     
==========================================
  Files          83       84       +1     
  Lines        3635     3645      +10     
==========================================
+ Hits         1365     1370       +5     
- Misses       2270     2275       +5     
Impacted Files Coverage Δ
qgis-app/base/views/processing_view.py 31.33% <0.00%> (ø)
qgis-app/base/forms/processing_forms.py 66.66% <40.00%> (-11.91%) ⬇️
qgis-app/layerdefinitions/tests/test_forms.py 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9debebd...03ff279. Read the comment docs.

@sumandari sumandari marked this pull request as ready for review January 13, 2022 01:44
Copy link
Collaborator

@dimasciput dimasciput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@sumandari sumandari merged commit 418281c into qgis:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants