-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace 'Owners' by 'Collaborators' #254
Conversation
@dimasciput, are test failures my fault? :) |
@gacarrillor maybe just try to reopen the PR? What would you think about including https://pre-commit.com/ to avoid such errors in the future? |
that's a good idea, we can add that. |
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 37.72% 37.72%
=======================================
Files 88 88
Lines 3714 3714
=======================================
Hits 1401 1401
Misses 2313 2313 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yes, now tests are passing 👍
It sounds good to have a pre-commit check. Nonetheless, the error my PR was getting, namely:
... is totally unrelated to the code (not really code) changes I'm suggesting. 😛 |
Hi @gacarrillor, can you rebase first please. |
The word 'Owner' seems to be even more powerful than the other roles. Namely, 'Authors' and 'Maintainers'. 'Collaborator' fits better with the original intention, i.e., enable teammates to collaborate uploading newer plugin versions. Note this just replaces the alias and doesn't touch the model.
Hi @dimasciput, sure! |
@gacarrillor thanks, this looks good |
Thank you @dimasciput and thanks to @elpaso for his help! |
The word 'Owner' seems to be even more powerful than the other roles. Namely, 'Authors' and 'Maintainers'.
'Collaborator' fits better with the original intention, i.e., enable teammates to collaborate uploading newer plugin versions.
Note this just replaces the alias and doesn't touch the model.