Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit lint hook for local dev #258

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

faebebin
Copy link
Contributor

Add pre-commit hook to catch lint erros early before pushing. No more waiting for ci pipeline.

@codecov-commenter
Copy link

Codecov Report

Merging #258 (8d26156) into master (ae40e70) will decrease coverage by 36.43%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #258       +/-   ##
===========================================
- Coverage   74.15%   37.72%   -36.44%     
===========================================
  Files         124       88       -36     
  Lines        4705     3714      -991     
===========================================
- Hits         3489     1401     -2088     
- Misses       1216     2313     +1097     
Impacted Files Coverage Δ
qgis-app/styles/tests/test_views.py 19.17% <0.00%> (-80.83%) ⬇️
qgis-app/api/tests/test_views.py 13.09% <0.00%> (-79.17%) ⬇️
qgis-app/styles/tests/test_filehandler.py 21.78% <0.00%> (-78.22%) ⬇️
qgis-app/styles/file_handler.py 9.09% <0.00%> (-77.28%) ⬇️
qgis-app/models/tests/test_views.py 23.41% <0.00%> (-76.59%) ⬇️
qgis-app/geopackages/tests/test_views.py 25.35% <0.00%> (-74.65%) ⬇️
qgis-app/wavefronts/tests/test_view.py 25.64% <0.00%> (-74.36%) ⬇️
qgis-app/layerdefinitions/tests/test_views.py 27.90% <0.00%> (-72.10%) ⬇️
qgis-app/wavefronts/tests/test_validator.py 28.26% <0.00%> (-71.74%) ⬇️
qgis-app/wavefronts/validator.py 24.28% <0.00%> (-70.00%) ⬇️
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dimasciput
Copy link
Collaborator

thanks! this is very helpful.

@dimasciput dimasciput merged commit 907eaaf into qgis:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants