Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show plugin tags as modal #268

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Conversation

faebebin
Copy link
Contributor

@faebebin faebebin commented Dec 14, 2022

After playing around I prefer this modal / popup way to a dedicated page, which would be a bit unelegant and also involves more changes.
@kannes , @m-kuhn what you think?

So now tags could be browsed like this on desktop:

Screenshot from 2022-12-14 10-07-02
Screenshot from 2022-12-14 10-08-04
Screenshot from 2022-12-14 10-07-15

And like this on mobile:

Screenshot from 2022-12-14 10-05-14
Screenshot from 2022-12-14 10-08-30
Screenshot from 2022-12-14 10-06-35
On mobile the content is at the bottom for better thumb access.

@kannes
Copy link
Contributor

kannes commented Dec 14, 2022

I like the idea a lot! Maybe there could be some indicator on the button that it will expand something as opposed to navigating to a new site? Something like ⏫ ⏬△ ▽ ︿ ﹀ ︽ ︾

@faebebin
Copy link
Contributor Author

faebebin commented Dec 15, 2022

Yes good idea. What about this full-screen icon?

image

Also I tought it also looks a bit heavy and removed the "button" - look. What you think?

@codecov-commenter
Copy link

Codecov Report

Base: 37.64% // Head: 37.64% // No change to project coverage 👍

Coverage data is based on head (722a328) compared to base (8d70d06).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   37.64%   37.64%           
=======================================
  Files          89       89           
  Lines        3740     3740           
=======================================
  Hits         1408     1408           
  Misses       2332     2332           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kannes
Copy link
Contributor

kannes commented Dec 15, 2022

👍 from me, thank you so much for this!

@faebebin
Copy link
Contributor Author

@m-kuhn , @elpaso feel free to merge if you like ?

@m-kuhn
Copy link
Member

m-kuhn commented Dec 15, 2022

Thanks @faebebin, looks good !
I don't have any commit rights on this repository, happy if someone else can do that.

Copy link
Collaborator

@dimasciput dimasciput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@dimasciput dimasciput merged commit a325058 into qgis:master Dec 17, 2022
@dimasciput
Copy link
Collaborator

@faebebin this has been deployed to plugins.qgis.org, please give it a try

@faebebin
Copy link
Contributor Author

faebebin commented Dec 17, 2022

@dimasciput thanks. Works, but the css bootstrap overrides did not apply. Did you run python manage.py collec tstatic on production?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants