-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show plugin tags as modal #268
Conversation
I like the idea a lot! Maybe there could be some indicator on the button that it will expand something as opposed to navigating to a new site? Something like ⏫ ⏬△ ▽ ︿ ﹀ ︽ ︾ |
Codecov ReportBase: 37.64% // Head: 37.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 37.64% 37.64%
=======================================
Files 89 89
Lines 3740 3740
=======================================
Hits 1408 1408
Misses 2332 2332 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
👍 from me, thank you so much for this! |
Thanks @faebebin, looks good ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
@faebebin this has been deployed to plugins.qgis.org, please give it a try |
@dimasciput thanks. Works, but the css bootstrap overrides did not apply. Did you run |
After playing around I prefer this modal / popup way to a dedicated page, which would be a bit unelegant and also involves more changes.
@kannes , @m-kuhn what you think?
So now tags could be browsed like this on desktop:
And like this on mobile:
On mobile the content is at the bottom for better thumb access.