Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve non-ASCII characters when downloading a zip #342

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Jan 10, 2024

Changes summary

  • Preserve non-ASCII characters by using escape_uri_path

image

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (a9dabb5) 36.97% compared to head (f75ffd7) 36.91%.

Files Patch % Lines
qgis-app/styles/tests/test_views.py 18.75% 13 Missing ⚠️
qgis-app/base/views/processing_view.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   36.97%   36.91%   -0.06%     
==========================================
  Files         106      106              
  Lines        4500     4518      +18     
==========================================
+ Hits         1664     1668       +4     
- Misses       2836     2850      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xpirix Xpirix marked this pull request as draft January 17, 2024 16:11
@Xpirix Xpirix marked this pull request as ready for review January 18, 2024 05:58
@dimasciput dimasciput merged commit a881607 into qgis:master Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants