Fix plugin detail rating #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
+ Coverage 36.06% 36.08% +0.01%
==========================================
Files 111 111
Lines 4899 4900 +1
==========================================
+ Hits 1767 1768 +1
Misses 3132 3132 ☔ View full report in Codecov by Sentry. |
pathmapper
reviewed
Feb 14, 2024
Comment on lines
+45
to
+59
| // The last star will depend on the decimal left | ||
| if(starIdx < initialRating) { | ||
| star.addClass('jquery-ratings-full'); | ||
| let ratingDiff = initialRating - starIdx | ||
| if (ratingDiff > 0 && ratingDiff <= 0.3) { | ||
| star.addClass('jquery-ratings-quarter'); | ||
| } | ||
| else if (ratingDiff > 0.3 && ratingDiff <= 0.6) { | ||
| star.addClass('jquery-ratings-half'); | ||
| } | ||
| else if (ratingDiff > 0.6 && ratingDiff <= 0.9) { | ||
| star.addClass('jquery-ratings-half-and-quarter'); | ||
| } | ||
| else { | ||
| star.addClass('jquery-ratings-full'); | ||
| } |
There was a problem hiding this comment.
Cool, thanks 👍 On a first sight I was wondering about the uneven distribution >0.3 <= 0.6 for the "half star", but how you implemented it, every "partial star" is displayed for a range of 0.3 which is fine. With the stars it's hard to spot how many decimals are represented anyway :-)
dimasciput
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary