Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTC timezone to xml #360

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Feb 14, 2024

Changes summary

  • Update local_timezone filter to return directly utcdate
  • Apply the filter to the created date and updated date

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (998e0b5) 36.06% compared to head (50f2585) 36.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   36.06%   36.06%           
=======================================
  Files         111      111           
  Lines        4899     4899           
=======================================
  Hits         1767     1767           
  Misses       3132     3132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pathmapper
Copy link
Contributor

Thanks, so the list delivers always these dates in UTC, right?

@Xpirix
Copy link
Collaborator Author

Xpirix commented Feb 14, 2024

@pathmapper My pleasure.

so the list delivers always these dates in UTC, right?

Yes, I just added the timezone to be more precise. I was also thinking about a format with the user timezone like in the plugin details but I wonder if it's acceptable by the plugin manager, it also involves using javascript and could change the inner content by adding another tag.

image

@pathmapper
Copy link
Contributor

I think UTC is fine and the plugin manager should handle to display local timezones if wanted.

@dimasciput
Copy link
Collaborator

@Xpirix could you test this on the qgis too

@Xpirix
Copy link
Collaborator Author

Xpirix commented Feb 19, 2024

@dimasciput Sure, I've tested on QGIS and successfully retrieved my test plugin with UTC datetime.

In the xml list:
image

In the plugin manager:
image

@Xpirix Xpirix changed the title Add local timezone to xml Add UTC timezone to xml Feb 19, 2024
@dimasciput dimasciput merged commit 8dec75d into qgis:master Feb 20, 2024
2 checks passed
@Xpirix Xpirix deleted the add_local_timezone_to_xml branch February 20, 2024 07:32
@pathmapper
Copy link
Contributor

Plugin manager now shows the update_date in local time -> qgis/QGIS#56530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants