Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm dialog - group name - User Manual #9185

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

selmaVH1
Copy link
Collaborator

@selmaVH1 selmaVH1 commented Jul 31, 2024

ref #9157
Changes in the user manual, chapter QGIS processing framework.

Note: This PR will include more updates in User Manual.

@selmaVH1
Copy link
Collaborator Author

For some reason, I was convinced that there would be more changes like this in the User Manual, but I've checked it twice and don’t see anything else that needs to be changed. If you, @DelazJ, don’t have any suggestions, as far as I'm concerned, this PR can be merged.

@DelazJ
Copy link
Collaborator

DelazJ commented Aug 23, 2024

This feature modifies the title of the algorithms dialog, meaning that any screenshot of algorithm in the docs is affected. The text is good enough but there are more than these two screenshots in the framework chapter and tens in the training manual. The question is "to what extent should we put efforts into fixing this issue?".
I wouldn't consider the training manual as a hard requirement but IMO we should a minima align the user manual screenshots and update the ones e.g. in the log output at https://docs.qgis.org/3.34/en/docs/user_manual/processing/toolbox.html#logging-the-execution, the modeler at https://docs.qgis.org/3.34/en/docs/user_manual/processing/modeler.html#definition-of-the-workflow
and maybe in the batch editor https://docs.qgis.org/3.34/en/docs/user_manual/processing/batch.html#the-parameters-table (and maybe are there more? I'm on my phone...)

@selmaVH1
Copy link
Collaborator Author

update the ones e.g. in the log output at https://docs.qgis.org/3.34/en/docs/user_manual/processing/toolbox.html#logging-the-execution

This one has already been updated, but in the new commit, I changed "Basic statistic for fields" to "Centroids" to match the algorithm parameters image

the modeler at https://docs.qgis.org/3.34/en/docs/user_manual/processing/modeler.html#definition-of-the-workflow

I checked this one, and there is no change in the title of algorithms in modeler

@DelazJ
Copy link
Collaborator

DelazJ commented Aug 27, 2024

Thanks for checking @selmaVH1, and obviously I was using the 3.34 docs 😱 .

@DelazJ DelazJ merged commit 7f856d3 into qgis:master Aug 27, 2024
2 of 3 checks passed
@DelazJ
Copy link
Collaborator

DelazJ commented Aug 28, 2024

I checked this one, and there is no change in the title of algorithms in modeler

Fixed in qgis/QGIS#58502

@agiudiceandrea
Copy link
Contributor

I think these changes should backported to 3.34 docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants