-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Raster layer unique values report" area unit of measure #9257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes @agiudiceandrea
@@ -2511,7 +2511,8 @@ Python code | |||
|
|||
Raster layer unique values report | |||
--------------------------------- | |||
Returns the count and area of each unique value in a given raster layer. | |||
Returns the count and the area, expressed in the area unit of the layer's CRS, of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to read twice to get the meaning. How about, trying to simplify:
Returns the count and the area, expressed in the area unit of the layer's CRS, of | |
Returns the count and the area (in the unit of the layer's CRS) of |
OK. It is not really the crs unit but i hope people know that m
is not an area unit.
Or (based on the unit of the layer's CRS)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a native English speaker... "the area unit of the layer's CRS" is also used in the description of the output table. Why here is not understandable? Maybe we could use the same wording as proposed the description of the output table:
Returns the count and area of each unique value in a given raster layer. The calculation of the area is done in the area unit of the layer's CRS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good remark re area.
And +1 for splitting the sentence in two.
Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
@agiudiceandrea Thanks. May I let you suggest the changes in code repo? |
Goal:
The unit of measure of the total area of pixels with a certain value and the corresponding column name in the table generated by the algorithm are not always the square meters and "m²", but they depends on the unit of measure of the layer's CRS.
Not sure if the wording is the best one...
Ticket(s): qgis/QGIS#58685