Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Raster layer unique values report" area unit of measure #9257

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

agiudiceandrea
Copy link
Contributor

@agiudiceandrea agiudiceandrea commented Sep 13, 2024

Goal:

The unit of measure of the total area of pixels with a certain value and the corresponding column name in the table generated by the algorithm are not always the square meters and "m²", but they depends on the unit of measure of the layer's CRS.

Not sure if the wording is the best one...

Ticket(s): qgis/QGIS#58685

  • Backport to LTR documentation is requested

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @agiudiceandrea

@@ -2511,7 +2511,8 @@ Python code

Raster layer unique values report
---------------------------------
Returns the count and area of each unique value in a given raster layer.
Returns the count and the area, expressed in the area unit of the layer's CRS, of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read twice to get the meaning. How about, trying to simplify:

Suggested change
Returns the count and the area, expressed in the area unit of the layer's CRS, of
Returns the count and the area (in the unit of the layer's CRS) of

OK. It is not really the crs unit but i hope people know that m is not an area unit.
Or (based on the unit of the layer's CRS)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker... "the area unit of the layer's CRS" is also used in the description of the output table. Why here is not understandable? Maybe we could use the same wording as proposed the description of the output table:
Returns the count and area of each unique value in a given raster layer. The calculation of the area is done in the area unit of the layer's CRS.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good remark re area.
And +1 for splitting the sentence in two.

docs/user_manual/processing_algs/qgis/rasteranalysis.rst Outdated Show resolved Hide resolved
Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
@DelazJ DelazJ merged commit 0353283 into qgis:master Sep 16, 2024
2 of 3 checks passed
@DelazJ DelazJ added the backport release_3.34 On merge create a backported pull request to 3.34 label Sep 16, 2024
@DelazJ
Copy link
Collaborator

DelazJ commented Sep 16, 2024

@agiudiceandrea Thanks. May I let you suggest the changes in code repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3.34 On merge create a backported pull request to 3.34
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants