use null value when pasting as temporary layer and attributes cannot …

…be converted
qgis · Jul 4, 2024 · 1a0d81d · 1a0d81d
1 parent 47f7b3a
commit 1a0d81d
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -10662,10 +10662,10 @@ std::unique_ptr<QgsVectorLayer> QgisApp::pasteToNewMemoryVector()
     for ( int idx = 0; idx < layer->fields().count() && idx < it->attributeCount(); ++idx )
     {
       QVariant attr = it->attribute( idx );
-      if ( layer->fields().at( idx ).convertCompatible( attr ) )
-      {
-        it->setAttribute( idx, attr );
-      }
+      //if convertCompatible fails, it will replace attr with an appropriate null QVariant
+      //so we're calling setAttribute regardless, covering cases like 'Autogenerate' or 'nextVal()' on int fields.
+      layer->fields().at( idx ).convertCompatible( attr );
+      it->setAttribute( idx, attr );
     }
   }