-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When building on proj >= 6.2, show the full scope and remarks for coordinate operations #30501
Conversation
for coordinate operations Gives much more useful information to users to allow them to make informed choices about suitable operations
ping @rduivenvoorde Here's what you see now: |
THANKS @rouault @nyalldawson !! Nice work! @nyalldawson I've seen this dialog popup now on a couple of incidents, and I think the average QGIS user is not aware of these details, and will have troubles deciding which Datum Transformation to choose. AND what all these 'words' mean... What about adding Help button in that dialog pointing to: Even better: if we add a chapter there which explains defines the differences between crs, projection, transformation, datum etc etc. Anybody a good primer for that? Personally I found the Esri page https://pro.arcgis.com/en/pro-app/help/mapping/properties/coordinate-systems-and-projections.htm a nice intro, though I do not know if we use the exact same definitions.. Still wonder if we should not remove the (1) (2), as I understand correct these will not respond to the order proj decides which is best... But grepping for it is too much... |
Chapter 4 of the EPSG Guidance Note 7-1 is a good source of information. It uses the same definitions as PROJ (well, ISO19111 really). |
@nyalldawson , a couple of UI/UX suggestions:
|
@nirvn I've already tweaked this a bit since the screenshot. Specifically:
|
@nyalldawson , sounds good. |
Done
I think we should leave these -- they are the only unique identifiers for the entries, and if we removed them it would prevent people making in-house instructional docs like "always select .... (2)".... |
Done
Done |
Cool! Thanks for the Help button. The first option now even shows 'Preferred transformation', |
I'd add the preferred transformation flag as an icon into the list view of all available transformation, and reuse that icon next to the preferred transformation text. |
@nirvn talking about (re)using icons: what do you think about using the CRS icon/button we have in the toolbar to use on all dialogs we have for online services (WMS/WFS/WCS/ArcGIS *Server etc)? |
Looks like you've flipped back to a proj < 6 build in your screenshot. You'd need to build proj master in order to see the newly added remarks and scope. What you're seeing instead is the information from QGIS' old datum transform database (i.e. - interpret with extreme caution!). An easy well to tell if you're using the shiny new stuff or the old dubious stuff is via the columns in this dialog. If you see two columns labeled "source transform" and "destination transform" - you're on the crufty old code path. If you see "transformation" and "accuracy" then you're on the new trustworthy path. |
Gives much more useful information to users to allow them to make informed choices about suitable operations.
Depends on OSGeo/PROJ#1537