Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building on proj >= 6.2, show the full scope and remarks for coordinate operations #30501

Merged
merged 4 commits into from
Jul 2, 2019

Conversation

nyalldawson
Copy link
Collaborator

Gives much more useful information to users to allow them to make informed choices about suitable operations.

Depends on OSGeo/PROJ#1537

for coordinate operations

Gives much more useful information to users to allow them to make
informed choices about suitable operations
@nyalldawson nyalldawson added the Projections/Transformations Related to coordinate reference systems or coordinate transformation label Jul 2, 2019
@nyalldawson nyalldawson added this to the 3.10.0 milestone Jul 2, 2019
@nyalldawson
Copy link
Collaborator Author

ping @rduivenvoorde

Here's what you see now:

image

image

image

@rduivenvoorde
Copy link
Contributor

rduivenvoorde commented Jul 2, 2019

THANKS @rouault @nyalldawson !! Nice work!

@nyalldawson I've seen this dialog popup now on a couple of incidents, and I think the average QGIS user is not aware of these details, and will have troubles deciding which Datum Transformation to choose. AND what all these 'words' mean...

What about adding Help button in that dialog pointing to:
https://docs.qgis.org/testing/en/docs/user_manual/working_with_projections/working_with_projections.html ?

Even better: if we add a chapter there which explains defines the differences between crs, projection, transformation, datum etc etc. Anybody a good primer for that? Personally I found the Esri page https://pro.arcgis.com/en/pro-app/help/mapping/properties/coordinate-systems-and-projections.htm a nice intro, though I do not know if we use the exact same definitions..

Still wonder if we should not remove the (1) (2), as I understand correct these will not respond to the order proj decides which is best... But grepping for it is too much...

@kbevers
Copy link

kbevers commented Jul 2, 2019

Anybody a good primer for that?

Chapter 4 of the EPSG Guidance Note 7-1 is a good source of information. It uses the same definitions as PROJ (well, ISO19111 really).

@nirvn
Copy link
Contributor

nirvn commented Jul 2, 2019

@nyalldawson , a couple of UI/UX suggestions:

  • might be worth transforming the label into a textbox to avoid long vertical dialogs when scope + remarks + proj strings are reflowing on too many lines.
  • I'd suggest using gray (i.e. disabled palette) font color for at least the proj string, and possibly the remarks too, to balance the focus a bit to more important strings.
  • Could you move the "[ x ] make default" checkbox to sit next to the [ OK ] button, it'd make it stand out a bit more as ATM it's kind of lost.

@nyalldawson
Copy link
Collaborator Author

@nirvn I've already tweaked this a bit since the screenshot. Specifically:

  • i use a text browser now, so the text is selectable (i think that also adds scrollbars?)
  • proj codes are rendered using tags

@nirvn
Copy link
Contributor

nirvn commented Jul 2, 2019

@nyalldawson , sounds good.

@nyalldawson
Copy link
Collaborator Author

@rduivenvoorde

What about adding Help button in that dialog pointing to:
https://docs.qgis.org/testing/en/docs/user_manual/working_with_projections/working_with_projections.html ?

Done

Still wonder if we should not remove the (1) (2), as I understand correct these will not respond to the order proj decides which is best... But grepping for it is too much...

I think we should leave these -- they are the only unique identifiers for the entries, and if we removed them it would prevent people making in-house instructional docs like "always select .... (2)"....

@nyalldawson
Copy link
Collaborator Author

@nirvn

I'd suggest using gray (i.e. disabled palette) font color for at least the proj string, and possibly the remarks too, to balance the focus a bit to more important strings.

Done

Could you move the "[ x ] make default" checkbox to sit next to the [ OK ] button, it'd make it stand out a bit more as ATM it's kind of lost.

Done

@nyalldawson nyalldawson merged commit 379190d into qgis:master Jul 2, 2019
@nyalldawson nyalldawson deleted the proj_ops branch July 2, 2019 19:11
@rduivenvoorde
Copy link
Contributor

Screenshot-20190703095907-712x566

Cool! Thanks for the Help button. The first option now even shows 'Preferred transformation',
making it a lot easier to choose!
(@nirvn making it green or red is too much?). I keep nagging about this because I think a lot of users will have no clue when they see this kind of dialogs :-)

@nirvn
Copy link
Contributor

nirvn commented Jul 3, 2019

I'd add the preferred transformation flag as an icon into the list view of all available transformation, and reuse that icon next to the preferred transformation text.

@rduivenvoorde
Copy link
Contributor

@nirvn talking about (re)using icons: what do you think about using the CRS icon/button we have in the toolbar to use on all dialogs we have for online services (WMS/WFS/WCS/ArcGIS *Server etc)?
(I'm talking about the red circled button in the screenshot below).
The good thing about it is also that it shows BOTH the EPSG code and the crs Name (in the tooltip though).
IF people agree, I wonder if we can make it a button which shows both code and name.
OR should it stay a 'Change' button? Instead of the 'Change...' button + crs name.
/me thinking about to make the ui a litte more consistent.
Also because in courses I use the epsg code, while in eg the wms dialog you students see the crs name there (and both Google Mercator and latlon have WGS84 in the name... giving name issues with them).
I also wonder if Tile size and Request step size are actually dependent on the CRS (as it is in that group box)...

Screenshot-20190703104213-866x699

@nyalldawson
Copy link
Collaborator Author

@rduivenvoorde

Looks like you've flipped back to a proj < 6 build in your screenshot. You'd need to build proj master in order to see the newly added remarks and scope. What you're seeing instead is the information from QGIS' old datum transform database (i.e. - interpret with extreme caution!).

An easy well to tell if you're using the shiny new stuff or the old dubious stuff is via the columns in this dialog. If you see two columns labeled "source transform" and "destination transform" - you're on the crufty old code path. If you see "transformation" and "accuracy" then you're on the new trustworthy path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projections/Transformations Related to coordinate reference systems or coordinate transformation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants