Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set color for rendering nodata pixels in raster layers #31728

Merged
merged 2 commits into from
Oct 27, 2019

Conversation

nyalldawson
Copy link
Collaborator

Allows raster nodata pixels to be colored in a specific (non-transparent) color. Designed to match the "Display background value" option from ArcMap.

Sponsored by SLYR

@nyalldawson nyalldawson added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Feature Frozen Feature freeze - Do not merge! labels Sep 13, 2019
@nyalldawson nyalldawson added this to the 3.12 milestone Sep 13, 2019
@nirvn
Copy link
Contributor

nirvn commented Sep 13, 2019

This was reported a while back as an implementation gap by ESRI users migrating to QGIS (see for e.g. issue #26087).

@nirvn
Copy link
Contributor

nirvn commented Sep 13, 2019

@nyalldawson , tested the branch, nodata color working with all of our raster renderers, and the UI looks nice. Good job:
Screenshot from 2019-09-13 14-47-45

@stale
Copy link

stale bot commented Sep 27, 2019

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 27, 2019
@stale
Copy link

stale bot commented Oct 4, 2019

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@stale stale bot closed this Oct 4, 2019
@nyalldawson nyalldawson removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Oct 14, 2019
@nyalldawson nyalldawson reopened this Oct 14, 2019
…er layers

Allows raster nodata pixels to be colored in a specific (non-transparent) color.
Designed to match the "Display background value" option from ArcMap.

Sponsored by SLYR

Fixes qgis#26087
@nyalldawson nyalldawson removed the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Oct 14, 2019
@nyalldawson nyalldawson added the Merge After Thaw For approved PRs which are ready to be merged as soon as master is thawed label Oct 14, 2019
@nyalldawson nyalldawson removed the Frozen Feature freeze - Do not merge! label Oct 26, 2019
@nyalldawson nyalldawson merged commit 626d83d into qgis:master Oct 27, 2019
@nyalldawson nyalldawson deleted the nodatacolor branch October 27, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Merge After Thaw For approved PRs which are ready to be merged as soon as master is thawed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants