[FEATURE][diagrams] New diagram type "stacked bars" #33043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
approved these changes
Nov 24, 2019
| @@ -39,6 +39,21 @@ class CORE_EXPORT QgsDiagram | |||
| { | |||
| public: | |||
|
|
|||
| #ifdef SIP_RUN | |||
| SIP_CONVERT_TO_SUBCLASS_CODE | |||
| if ( sipCpp->diagramName() == QStringLiteral( "Pie" ) ) | |||
There was a problem hiding this comment.
Nice; that sip conversion could probably make its way into 3.10 (minus the stacked bit)
There was a problem hiding this comment.
Yep, definitely. (that said, it's actually not that vital given that the subclasses don't really expose anything useful)
Stacks bars of varying colors for each attribute on top of each other vertically or horizontally. Sponsored by SLYR
|
Hi there, just tested it when checking the diagram issue and I noticed there was always a gap between categories. And when checking the validation images of this PR the gap is also there. I wanted to know if it was intended as I thought it was a bug. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks bars of varying colors for each attribute on top of each other
vertically or horizontally.
Designed to match the "Stacked" chart renderer option available in ArcGIS.
Sponsored by SLYR