Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "stepped line" and "hollow" scalebar styles #35238

Merged
merged 6 commits into from
Mar 22, 2020

Conversation

nyalldawson
Copy link
Collaborator

Adds two new scalebar styles (which are available in ArcMap, but previously impossible to reproduce in QGIS)

Stepped line style:

image

Hollow (aka "south african") style:

image

Also includes the api cleanups suggested in #35225

Sponsored by SLYR

Designed to match the appearance and behavior of the ArcMap equivalent,
this was a scalebar format which was previously impossible to replicate
in QGIS.

Also fixes qgis#26589

Sponsored by SLYR
This matches the "hollow" scalebar style from ArcMap, and is a style
used in South African mapping standards

Fixes qgis#20390

Sponsored by SLYR
…enderer

subclasses, so that the subclass itself can indicate what settings
it respects and we can avoid all the hardcoded logic in the configuration
widget
@nyalldawson nyalldawson added Feature Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks labels Mar 22, 2020
@nyalldawson nyalldawson requested a review from nirvn March 22, 2020 10:08
@github-actions github-actions bot added this to the 3.14.0 milestone Mar 22, 2020
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@nyalldawson nyalldawson merged commit d10267f into qgis:master Mar 22, 2020
@nyalldawson nyalldawson deleted the stepped branch March 22, 2020 17:08
@timlinux timlinux added Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels May 22, 2020
@agiudiceandrea
Copy link
Member

These bug reports #38369 and #37413 belongs to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants