Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE][layouts] New item type for marker symbols #35576

Merged
merged 2 commits into from
Apr 5, 2020
Merged

[FEATURE][layouts] New item type for marker symbols #35576

merged 2 commits into from
Apr 5, 2020

Conversation

nyalldawson
Copy link
Collaborator

Allows marker symbols to be placed directly on layouts, eg. for manually placing markers over a map item or for creation of advanced custom legends.

(previously you had to hack support for these, e.g. by drawing rectangles using centroid fill symbols. Much nicer to have a dedicated item type for it, allowing more specific customisation options (coming soon!))

Sponsored by SLYR

image

@nyalldawson nyalldawson added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Feature Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. labels Apr 4, 2020
@qgis-bot
Copy link
Collaborator

qgis-bot commented Apr 4, 2020

@nyalldawson
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@nirvn
Copy link
Contributor

nirvn commented Apr 4, 2020

Instantly felt in love with the item's icon :)

This will greatly help in making custom legends, thanks.

@github-actions github-actions bot added this to the 3.14.0 milestone Apr 4, 2020
@nyalldawson
[FEATURE][layouts] New item type for marker symbols
cfffecf 
Allows marker symbols to be placed directly on layouts, eg.
for manually placing markers over a map item or for creation
of advanced custom legends
@nyalldawson
Allow layout items to be created without rubber bands, e.g. so that
ebf8392 
marker items are placed with a single click instead of click-and-drag
@nyalldawson nyalldawson removed the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Apr 4, 2020
@nyalldawson
Copy link
Collaborator Author

This is ready for merge now

nirvn
nirvn approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, merge away.

@nyalldawson nyalldawson merged commit 0fe2ec2 into qgis:master Apr 5, 2020
@nyalldawson nyalldawson deleted the marker_item branch April 5, 2020 04:23
@qgis-bot qgis-bot mentioned this pull request Apr 5, 2020
Closed
@qgis-bot
Copy link
Collaborator

qgis-bot commented Apr 5, 2020

@nyalldawson
A documentation ticket has been opened at qgis/QGIS-Documentation#5231
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@timlinux timlinux added Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirvn nirvn nirvn approved these changes

Assignees
No one assigned
Labels
Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks
Projects
None yet
Milestone
3.14 (Feature)
Development

Successfully merging this pull request may close these issues.
4 participants
@nyalldawson @qgis-bot @nirvn @timlinux