Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control over the horizontal spacing before legend group/subgroup/symbols #35974

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

nyalldawson
Copy link
Collaborator

Gives flexibility to allow "nesting" legend groups/subgroups/symbols and much greater control over legend item placement

Sponsored by SLYR

legend group/subgroup/symbols

Gives flexibility to allow "nesting" legend groups/subgroups/symbols
and much greater control over legend item placement

Sponsored by SLYR
@nyalldawson nyalldawson added Feature Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks labels Apr 24, 2020
@github-actions github-actions bot added this to the 3.14.0 milestone Apr 24, 2020
@nyalldawson nyalldawson merged commit 36339c2 into qgis:master Apr 24, 2020
@nyalldawson nyalldawson deleted the legend_spacing branch April 24, 2020 18:50
@roya0045
Copy link
Contributor

I'm a little late to the party but I was curious if you think this could possibly affect right-to-left text.

Question regarding good practice: Should we also make tests with right-to-left tests as good practice with the legend or should we assume that no error will occur until a ticket is submitted?

@nyalldawson
Copy link
Collaborator Author

I did test that already, and there's a unit test here checking that the spacing works correctly on right aligned text.

@nirvn and I debated whether to expose seperate controls for left and right spacing, but decided that this would complicate the UI too much so deferred that until there's a proven need for that level of control.

@roya0045
Copy link
Contributor

@nyalldawson I saw the image but I was not sure if language such as arabic are handled the same as english in this case. I guess it shouldn't have an effect.

@timlinux timlinux added Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants