Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new mesh layer #43873

Merged
merged 5 commits into from
Jul 13, 2021
Merged

create new mesh layer #43873

merged 5 commits into from
Jul 13, 2021

Conversation

vcloarec
Copy link
Member

@vcloarec vcloarec commented Jun 23, 2021

In the scope of mesh layer editing (qgis/QGIS-Enhancement-Proposals#228), the aim of this PR is to allow the user to create new frame of mesh layer.
From the dialog, the user can create:

  • an empty mesh layer
  • a frame based on an existing mesh in the project
  • a frame based on a existing mesh from a file

To work fine, this new functionality needs few changes in MDAL that are coming...

createNewMesh_1

createNewMesh_2

createNewMesh_3

@github-actions github-actions bot added this to the 3.22.0 milestone Jun 23, 2021
@vcloarec vcloarec added Feature Mesh Related to general mesh layer handling (not specific data formats) GUI/UX Related to QGIS application GUI or User Experience NOT FOR MERGE Don't merge! labels Jun 23, 2021
src/ui/mesh/qgsnewmeshlayerdialogbase.ui Outdated Show resolved Hide resolved
src/ui/mesh/qgsnewmeshlayerdialogbase.ui Outdated Show resolved Hide resolved
src/ui/mesh/qgsnewmeshlayerdialogbase.ui Outdated Show resolved Hide resolved
src/ui/mesh/qgsnewmeshlayerdialogbase.ui Outdated Show resolved Hide resolved
@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jun 25, 2021
@PeterPetrik
Copy link
Contributor

@vcloarec why this has label "not for merge?"

@vcloarec
Copy link
Member Author

@PeterPetrik , because waiting of MDAL update to finalize the PR and to be sure the QGIS community doesn't see objection for this new feature.
Now the PR is finalized.

@PeterPetrik PeterPetrik added Squash! Remember to squash this PR, instead of merging or rebasing and removed NOT FOR MERGE Don't merge! labels Jul 13, 2021
@PeterPetrik PeterPetrik self-requested a review July 13, 2021 05:36
@PeterPetrik PeterPetrik merged commit 494735a into qgis:master Jul 13, 2021
tomkralidis pushed a commit to tomkralidis/QGIS that referenced this pull request Aug 22, 2021
[mesh] [feature] adds a option to create blank/scratch mesh frame (vertices/faces)
@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature GUI/UX Related to QGIS application GUI or User Experience Mesh Related to general mesh layer handling (not specific data formats) Squash! Remember to squash this PR, instead of merging or rebasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants