Georeferencer preview point fixes #57984
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uclaros
added
Bug
roya0045
reviewed
Jul 4, 2024
| @@ -92,13 +92,18 @@ void QgsGeorefDataPoint::setEnabled( bool enabled ) | |||
|
|
|||
| void QgsGeorefDataPoint::setId( int id ) | |||
| { | |||
| const bool noLongerTemporary = mId < 0 && id >= 0; | |||
There was a problem hiding this comment.
Variable name doesn't seem optimal, maybe "isValid" or "isPermanent"?
There was a problem hiding this comment.
We only want to change the color if this call changes the point form a temporary ( < 0 ) to a permanent, hence the noLonger in the name
nyalldawson
added
backport queued_ltr_backports
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #44986
Fixes #44987
Fixes #44988
Also fixes old unreported regression: residual bars are now updated while moving GCPs