Create converter for ArcGis FeatureServer type classBreaks #58058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Small cleanup" This reverts commit e298ec3. Small cleanup Rename testRenderer to testCategorizedRenderer Add unit test for the gradated renderer Check authoring info first for classification mode Set correct classifier for esriClassifyEqualInterval Set classification method Add classBreakInfos stops Move last label down by one to be set right Set transparency of default symbol Only set last range when type is colorInfo Display all ranges Use for loop instead of next() for visualVariables Set breakpoints wit symbols Set default symbol of renderer Set attribute name of renderer Return QgsGraduatedSymbolRenderer instead of nullptr
nyalldawson
reviewed
Jul 11, 2024
|
Nice work @merydian ! In order to fix the failing indentation tests you'll need to run the "scripts/astyle_all.sh" script over your branch. That'll auto-apply the required indentation and flake formatting. (It's easiest to set this up as a pre-commit hook using the scripts/prepare_commit.sh script, so that all the formatting and such is automatically applied for you!) |
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
nyalldawson
reviewed
Jul 12, 2024
Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
nyalldawson
reviewed
Jul 17, 2024
nyalldawson
added
the
Squash!
nyalldawson
reviewed
Jul 17, 2024
nyalldawson
reviewed
Jul 17, 2024
nyalldawson
reviewed
Jul 17, 2024
nyalldawson
approved these changes
Jul 17, 2024
|
Nice work @merydian ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The file qgsarcgisrestutils.cpp is currently not supporting "classBreaks" type ArcGis-FeatureServers. This pull request adds functionality for QGIS to automatically convert classBreaks FeatureServer into a QgsGraduatedSymbolRenderer. Symbology will be loaded automatically now.