Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement converter for esriTS symbols for featureServers #58076

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Implement converter for esriTS symbols for featureServers #58076

merged 11 commits into from
Jul 17, 2024

Commits on Jul 11, 2024

  1. Implement parseEsriTextMarkerSymbolJson 

    Implement parseEsriTextMarkerSymbolJson

Add test for chr parameter

Set chr parameter to text

Implement borderLineSize width

Add test for borderLineSize

Add test for strokeColor

Implement strokeColor

Implement anchor points

Add tests for anchor points

Add test for angle

Add test for offset

Set sizeUnit

Set offset

Remove fontData map

Add more specific tests

Create parseEsriTextMarkerSymbolJson function

Add tests

Add necessary additional information to test json
    @merydian
    merydian committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    76f6a14 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Refactor variable declarations and assignments to use const where a… 

    …ppropriate

Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
    @merydian @nyalldawson
    merydian and nyalldawson committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    629e09c View commit details
    Browse the repository at this point in the history

  2. Set stroke width unit to points

    @merydian
    merydian committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4a03f76 View commit details
    Browse the repository at this point in the history

  3. Revert formatting of additional files

    @merydian
    merydian committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    bae2f47 View commit details
    Browse the repository at this point in the history

  4. Check for hex instead of single rgb value 

    Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
    @merydian @nyalldawson
    merydian and nyalldawson committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e9dd136 View commit details
    Browse the repository at this point in the history

  5. Set angle value in test json to 45 

    Co-authored-by: Nyall Dawson <nyall.dawson@gmail.com>
    @merydian @nyalldawson
    merydian and nyalldawson committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8063fb7 View commit details
    Browse the repository at this point in the history

  6. Add test for main color

    @merydian
    merydian committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    99e0a24 View commit details
    Browse the repository at this point in the history

  7. Create angle converter

    @merydian
    merydian committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d296b07 View commit details
    Browse the repository at this point in the history

  8. Correct testing color for strokeColor

    @merydian
    merydian committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0f3e00b View commit details
    Browse the repository at this point in the history

  9. Run astyle_all.sh

    @merydian
    merydian committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a92819d View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Apply suggestions from code review

    @nyalldawson
    nyalldawson committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    cf2d1aa View commit details
    Browse the repository at this point in the history