-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make coordinates of vector data chunks independent from scene origin #59174
base: master
Are you sure you want to change the base?
Make coordinates of vector data chunks independent from scene origin #59174
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
This is a continuation of work started in qgis#58948, handling all the cases of data from vector layers.
2b7c460
to
2c65c3a
Compare
Tests failed for Qt 6One or more tests failed using the build from commit ea6be97 polygon3d_extrusion_textured_phong (testExtrudedPolygonsTexturedPhong)polygon3d_extrusion_textured_phongTest failed at testExtrudedPolygonsTexturedPhong at tests/src/3d/testqgs3drendering.cpp:593 Rendered image did not match tests/testdata/control_images/3d/expected_polygon3d_extrusion_textured_phong/default/expected_polygon3d_extrusion_textured_phong.png (found 439 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Tests failed for Qt 5One or more tests failed using the build from commit 2c65c3a polygon3d_extrusion_gooch_shading (testExtrudedPolygonsGoochShading)polygon3d_extrusion_gooch_shadingTest failed at testExtrudedPolygonsGoochShading at tests/src/3d/testqgs3drendering.cpp:872
sphere_rendering (testInstancedRendering)sphere_renderingTest failed at testInstancedRendering at tests/src/3d/testqgs3drendering.cpp:1599
sphere_rendering_clipping (testInstancedRenderingClipping)sphere_rendering_clippingTest failed at testInstancedRenderingClipping at tests/src/3d/testqgs3drendering.cpp:1680 Rendered image did not match tests/testdata/control_images/3d/expected_sphere_rendering_clipping/expected_sphere_rendering_clipping.png (found 3225 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
The texture was barely visible at all, so let's magnify it
We just flip axes at the transform where needed back to world coordinates. Make instanced renderer shader respect any QTransform and clean up its code
Flipping back to world coordinates is done in QTransform
7e2ac2f
to
4f75f77
Compare
This is a continuation of work started in #58948, handling all the cases of data from vector layers. No change of functionality, just changing what coordinates are stored in geometries sent to GPU.
Also: