-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui][diagrams] Fix drag and drop to reorder stacked diagram not working #60278
base: master
Are you sure you want to change the base?
Conversation
…rts of QGIS and provide larger drop area
… view using night mapping
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Thanks @nirvn
Some options of subdiagrams not topmost are currently greyed out. My suggestion was to allow any diagram options to be modified anytime, regardless the rank of the subdiagram, and then have a method that would apply only placement options from the topmost to the whole stack. That way, a simple-drag-and-drop would be enough to preview what I expect, and not require subsequent placement options modifications. And if I switch again the order...? |
@DelazJ , let's merge this PR which gives us generic re-ordering support here and deal with the extra UX enhancements you mentioned in subsequent PRs if that's OK with you. |
Description
This PR fixes #59505 whereas the stacked diagrams tree view was not allowing for drag and drop re-ordering of sub-diagrams. It's an important UI/UX that users would definitively expect here as we allow for drag and drop re-ordering for symbology renderers and rule-based label renderer widgets.
In addition, while fixing this, I've harmonized the tree view by removing the "Enabled" column in favor of adding a checkbox in the first column where the diagram name is located (like we do pretty much everywhere else), as well as adding a nice touch of night mapping (eye toggles!).