Better distinguish Arcgis feature/map icons in the browser #60459
+134
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a partial revival of #58454 which aims to improve how Arcgis REST services appear in the browser, to distinguish a bit better between map services and feature services. Instead of the initial approach in #58454 (which added the type as text in the label), this uses two icons variants. It doesn't change the tooltip, as the tooltip shows the URL which already contains this information (last part of the URL).
While at it, this PR also improves (I think) the icons for Arcgis REST services by putting the esri logo in bigger (the icons are so small, it was barely recognizable). I can revert that if you think it's not worth the change (in regards to user docs or trademark issues even if the logo was in there already).
Let's hope we can get this merged, as it's one small commit for QGIS, but one giant leap into opensource geospatial for yet another swiss administration :-D
Icons
*: defined in QgsAmsProvider.cpp, but couldn't find it used anywhere ?
Screenshot