Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better distinguish Arcgis feature/map icons in the browser #60459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olivierdalang
Copy link
Contributor

Description

This is a partial revival of #58454 which aims to improve how Arcgis REST services appear in the browser, to distinguish a bit better between map services and feature services. Instead of the initial approach in #58454 (which added the type as text in the label), this uses two icons variants. It doesn't change the tooltip, as the tooltip shows the URL which already contains this information (last part of the URL).

While at it, this PR also improves (I think) the icons for Arcgis REST services by putting the esri logo in bigger (the icons are so small, it was barely recognizable). I can revert that if you think it's not worth the change (in regards to user docs or trademark issues even if the logo was in there already).

Let's hope we can get this merged, as it's one small commit for QGIS, but one giant leap into opensource geospatial for yet another swiss administration :-D

Icons

before after (wms/wfs icon for reference)
arcgis rest server image mIconAfs mIconWfs
arcgis map server* image mIconAms mIconWms
arcgis feature service image mIconAfs mIconWfs
arcgis map service image mIconAms mIconWms

*: defined in QgsAmsProvider.cpp, but couldn't find it used anywhere ?

Screenshot

before after
image image

@github-actions github-actions bot added this to the 3.42.0 milestone Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit d0c5256)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit d0c5256)

@olivierdalang olivierdalang force-pushed the 2025-01-28_browser-arcgisrest branch 2 times, most recently from 449e367 to 3f2d3ac Compare February 5, 2025 13:17
@olivierdalang olivierdalang force-pushed the 2025-01-28_browser-arcgisrest branch from 3f2d3ac to d0c5256 Compare February 5, 2025 15:26
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 20, 2025
@nyalldawson nyalldawson added the Frozen Feature freeze - Do not merge! label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frozen Feature freeze - Do not merge! stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants