-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mesh] [feature] App widgets for styling mesh layers #7313
Conversation
- Adding datasets to mesh layer from properties panel - Information and source panel in properties panel - Selection of active dataset (properties or styling panel) - Styling of contours/scalars (properties or styling panel) - Styling of mesh frame (properties or styling panel) - Styling of vector arrows (properties or styling panel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-kuhn I have already reviewed Peter's code earlier (PeterPetrik#13) so for me this PR is +1. Another pair of eyes would be useful, but I know it is a lot of code :-)
The good news is that this is probably the last big chunk of mesh-related code and further updates should be much more manageable incremental improvements.
I had a brief flick through the code and it looks good to me. I have a couple of UX issues from looking at the screencast. I haven't built, so these may be non-issues, but:
|
Couple of styling UI/UX thoughts:
IMHO, that'll make for a much cleaner and clearer UI. As for the color shader widget, nice, +1 for integrating it for the pseudocolor too. BTW, one thing that'd be nice to implement is for the color ramp button to have its ramp updating when the user manually updates the list (steps, colors, etc.). |
+1 to @nirvn's UI proposal |
@nyalldawson @nirvn fixed review issues... |
@PeterPetrik , spectacular UI improvements! |
It is indeed a lot better than the first try, thank you for suggestions! |
Shouldn't the labels aligned on left? I can see in the Styling panel some checkboxes or group titles (?) that are centered and as far as I remember, this not the usual placement of the options... |
Thanks for the explanation @wonder-sk |
App widgets for styling mesh layers
The mesh layer properties could be now styled from properties or
style panel similar to vector or raster layers. These new
actions were introduced in the pull request.
The contours/raster datasets are styled with new
QgsColorShaderWidget
that was extracted from
QgsSingleBandPseudoColorRendererWidget
. Thiswidget should be used in both
QgsSingleBandPseudoColorRendererWidget
andQgsMeshRendererScalarSettingsWidget
in the future. But integration toQgsSingleBandPseudoColorRendererWidget
should be taken with extra care andI propose to do it in separate PR after this one.
Also, to keep this (already big enough) PR in acceptable size, these are known
limitations of the current implementation:
that contains data for same quantity (e.g. temperature) but over different time
(e.g. dataset group is "Temperature" and it consists of datasets "Temperature on Monday morning", "Temperature on Monday evening", ...). The current implementation is based
on naming convention of datasets.
Thanks to @wonder-sk for help and internal review of the code.
Relates to QEP-119