Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the design to match https://qgis.github.io/QGIS-Hugo/ #72

Merged
merged 16 commits into from
Aug 1, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Feb 20, 2024

Login page

image

Home page

image

Management page

image

Feed item form

image

Login page on mobile

image

Homepage on mobile

image

Feed form on mobile

image

Feed list and navigation menu on mobile

image

@Xpirix Xpirix marked this pull request as draft February 20, 2024 16:02
@Xpirix Xpirix changed the title Implement reusable component Update the design to match https://qgis.github.io/QGIS-Hugo/ Feb 21, 2024
@Xpirix Xpirix requested review from dimasciput and removed request for dimasciput February 21, 2024 13:34
@Xpirix Xpirix marked this pull request as ready for review February 21, 2024 13:35
@atsiatserkina
Copy link

hi @Xpirix ! I would suggest checking the styles of header and footer in few days again - on screenshots, I see that Donate button color is lighter than we made recently, and footer is grey but should have another color, see https://qgis.github.io/QGIS-Hugo/
Also I'm not sure if we made a dark small header transparent, I think it should have 100% filling. We will check it too.
Anyway, I really like how it looks with new style and fonts!

<!-- Icons -->
<link rel="stylesheet" href="{% static 'font-awesome/css/fontawesome.min.css' %}" type="text/css">

<script type="text/javascript" src="{% static "js/jquery.js" %}"></script>

<script type="text/javascript" src="https://konturio.github.io/qgis-uni-navigation/assets/index-I1cvcjQR.js"></script>
Copy link

@dqunbp dqunbp Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual URL will be https://konturio.github.io/qgis-uni-navigation/index.js

@Xpirix Xpirix marked this pull request as draft February 23, 2024 13:03
@Xpirix
Copy link
Collaborator Author

Xpirix commented Feb 26, 2024

Hi @atsiatserkina and @dqunbp , thanks for the review.
I've updated the main header, second header and footer style/content according to the current https://qgis.github.io/QGIS-Hugo/. You can see these through the screenshots in my first comment (#72 (comment)). I can always update them later if there are some new changes on QGIS-Hugo.

However, I noticed that all the links in the main header are relative and redirect me to pages that don't exist. I'm running the QGIS-Feed local environment on http://localhost:8000 and when I want to go to the download page from the header, it redirects me to http://localhost:8000/download which is not expected. How can I fix this? Is there any parameter I should set in the qg-top-nav tag?

@Xpirix Xpirix marked this pull request as ready for review February 26, 2024 10:41
@Xpirix Xpirix requested a review from dqunbp February 27, 2024 06:10
@dqunbp
Copy link

dqunbp commented Feb 27, 2024

Hi @atsiatserkina and @dqunbp , thanks for the review. I've updated the main header, second header and footer style/content according to the current https://qgis.github.io/QGIS-Hugo/. You can see these through the screenshots in my first comment (#72 (comment)). I can always update them later if there are some new changes on QGIS-Hugo.

However, I noticed that all the links in the main header are relative and redirect me to pages that don't exist. I'm running the QGIS-Feed local environment on http://localhost:8000 and when I want to go to the download page from the header, it redirects me to http://localhost:8000/download which is not expected. How can I fix this? Is there any parameter I should set in the qg-top-nav tag?

Hi @Xpirix !
There is a location-prefix parameter that should be used. In our case, it will be <qg-top-nav location-prefix="/QGIS-Hugo" .... We need to use it because the current QGIS Hugo site has this location, and we should remove it for production.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Feb 27, 2024

Thanks @dqunbp

@timlinux timlinux merged commit ddc8168 into qgis:master Aug 1, 2024
2 checks passed
@Xpirix
Copy link
Collaborator Author

Xpirix commented Aug 5, 2024

@timlinux Thanks for the merge. It has been deployed on feed.qgis.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants