-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sequence unrolling in flipping and flipping_signal #720
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
+ Coverage 97.23% 97.24% +0.01%
==========================================
Files 110 110
Lines 7618 7646 +28
==========================================
+ Hits 7407 7435 +28
Misses 211 211
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work as expected in the tries made with quantum machines. Albeit the speed-up in that case is not very significant, it is still there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not tested the PR on hardware, but the code seems to be fine.
Maybe one quick thing, could you add also tests with the option |
It adds support for sequence unrolling in flipping and flipping_signal as requested in qiboteam/qibolab_platforms_qrc#119. It has only been tested with dummy.
Checklist:
master
main
main