Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really disconnect QM (0.1) #1107

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Really disconnect QM (0.1) #1107

merged 2 commits into from
Dec 1, 2024

Conversation

stavros11
Copy link
Member

Removes the self.manager reference, so that QM is not available after calling platform.disconnect().

Note that in 0.2 this is already fixed:

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.85%. Comparing base (cc64ee1) to head (e46b12c).
Report is 3 commits behind head on 0.1.

Files with missing lines Patch % Lines
src/qibolab/instruments/qm/controller.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              0.1    #1107      +/-   ##
==========================================
- Coverage   69.88%   69.85%   -0.04%     
==========================================
  Files          64       64              
  Lines        6880     6883       +3     
==========================================
  Hits         4808     4808              
- Misses       2072     2075       +3     
Flag Coverage Δ
unittests 69.85% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stavros11 stavros11 merged commit bdf1adc into 0.1 Dec 1, 2024
23 of 24 checks passed
@stavros11 stavros11 deleted the qm-disconnect branch December 1, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants