Disconnect platform when job is interrupted #1110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the suggestion of #1108 for 0.1, which is what was primarily causing the temperature issues. Note that it will only work when the
Platform
interface is used, not the instruments directly, but this should capture most cases in practice. It may be possible to lower it to the drivers. If you agree, I can also port it to 0.2.I have tested and it seems that the handler is called successfully on qw11q when sbatch+scancel is used. It also works on dummy for both sbatch+scancel and srun+(Ctrl+C). However, srun+(Ctrl+C) does not seem to work on qw11q and the handler is skipped! I am not sure why.
I have also confirmed that the TWPA pump LO is turned off by the handler, which is not the case now (LO will remain on after job cancellation). I have not confirmed that QM jobs are properly cancelled, but I believe that
qibolab/src/qibolab/instruments/qm/controller.py
Line 260 in cc64ee1
should be taking care of this (will confirm soon).