-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop .settings
in Qblox modules
#736
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some trivial metrics (trivial, but still pleasing) # main # HEAD
143 acquisition.py 143 acquisition.py
758 cluster_qcm_bb.py 685 cluster_qcm_bb.py
759 cluster_qcm_rf.py 672 cluster_qcm_rf.py
1039 cluster_qrm_rf.py 952 cluster_qrm_rf.py
541 controller.py 524 controller.py
57 debug.py 57 debug.py
61 module.py 157 module.py
284 port.py 284 port.py
370 q1asm.py 370 q1asm.py
234 sequencer.py 234 sequencer.py
397 sweeper.py 402 sweeper.py
4643 total 4480 total
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 63.89% 64.17% +0.27%
==========================================
Files 49 49
Lines 5792 5792
==========================================
+ Hits 3701 3717 +16
+ Misses 2091 2075 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Superseded by #868 and the subsequent rewriting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the necessity of having the attribute
.settings
in each qblox module to store the settings loaded from the runcard.This was unnecessary since the port object already has the possibility to cache this values.
This PR also fix the test for Qblox controller (thanks @stavros11).
Closes #724
Note:
Checklist: