Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .settings in Qblox modules #736

Closed
wants to merge 11 commits into from
Closed

Conversation

PiergiorgioButtarini
Copy link
Contributor

@PiergiorgioButtarini PiergiorgioButtarini commented Jan 5, 2024

This PR remove the necessity of having the attribute .settings in each qblox module to store the settings loaded from the runcard.
This was unnecessary since the port object already has the possibility to cache this values.
This PR also fix the test for Qblox controller (thanks @stavros11).
Closes #724

Note:

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@PiergiorgioButtarini PiergiorgioButtarini marked this pull request as ready for review February 7, 2024 13:51
@alecandido
Copy link
Member

alecandido commented Feb 7, 2024

Some trivial metrics (trivial, but still pleasing)

# main                        # HEAD
    143 acquisition.py            143 acquisition.py
    758 cluster_qcm_bb.py         685 cluster_qcm_bb.py
    759 cluster_qcm_rf.py         672 cluster_qcm_rf.py
   1039 cluster_qrm_rf.py         952 cluster_qrm_rf.py
    541 controller.py             524 controller.py
     57 debug.py                   57 debug.py
     61 module.py                 157 module.py
    284 port.py                   284 port.py
    370 q1asm.py                  370 q1asm.py
    234 sequencer.py              234 sequencer.py
    397 sweeper.py                402 sweeper.py
   4643 total                    4480 total

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (8bb0327) 63.89% compared to head (614e301) 64.17%.

Files Patch % Lines
src/qibolab/instruments/qblox/cluster_qrm_rf.py 36.36% 7 Missing ⚠️
src/qibolab/instruments/qblox/port.py 72.00% 7 Missing ⚠️
src/qibolab/instruments/qblox/cluster_qcm_bb.py 54.54% 5 Missing ⚠️
src/qibolab/instruments/qblox/cluster_qcm_rf.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
+ Coverage   63.89%   64.17%   +0.27%     
==========================================
  Files          49       49              
  Lines        5792     5792              
==========================================
+ Hits         3701     3717      +16     
+ Misses       2091     2075      -16     
Flag Coverage Δ
unittests 64.17% <69.01%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scarrazza scarrazza added this to the Qibolab 0.1.6 milestone Feb 15, 2024
@alecandido
Copy link
Member

Superseded by #868 and the subsequent rewriting

@alecandido alecandido closed this Apr 22, 2024
@alecandido alecandido deleted the drop_settings branch August 5, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop self.settings in Qblox modules
5 participants