-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify qrm_rf driver so that qrm_rf modules can be used as qcm_rf to generate drive pulses. #800
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
==========================================
- Coverage 63.89% 63.88% -0.02%
==========================================
Files 49 49
Lines 5792 5793 +1
==========================================
Hits 3701 3701
- Misses 2091 2092 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aorgazf!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It is a minimal change so no objections in terms of code, @PiergiorgioButtarini feel free to merge if this solves the issue @biankawolo is having.
@PiergiorgioButtarini: in principle, we could make a minimal subclass making it clear that it is a qrm_rf used for this purpose. However, I'd postpone after the |
@alecandido yes we could but idk how much this will be really useful in the future. Consider that using the qrm as a drive module is a necessity due to the temporary lack of QcmRf and in the next weeks we should receive an order that will avoid this problem. |
I believe it is not a bad idea in general. Of course, it is better to use the qrm for what is made for, since it would be a waste in the long term. But this setup may happen, maybe even not only in the TII lab (provided that someone else is using Qibolab), as it happened for you know. |
Yes if we consider that other lab can have the same problem it might be a nice feature to have. Thanks I will open an issue and merge this! |
Co-authored-by: Stavros Efthymiou <35475381+stavros11@users.noreply.github.com>
The driver of the qrm_rf is modified so that if the qrm_rf does not receive any readout pulses, it does not trigger any acquisitions, allowing the use of the module for drive only.
The cluster connected to tii1q_d28 has 2 qrm_rf modules, due to the lack of acm_rf modules.
Checklist: