Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compiler rules when dealing with qubit strings #937

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

andrea-pasquale
Copy link
Contributor

The virtual phases were not properly updated when executing circuits containing strings.
Thanks @stavros11 for spotting the issue.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Jul 18, 2024
@andrea-pasquale andrea-pasquale self-assigned this Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.32%. Comparing base (11a34bd) to head (1d8e3e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #937   +/-   ##
=======================================
  Coverage   70.32%   70.32%           
=======================================
  Files          64       64           
  Lines        6679     6679           
=======================================
  Hits         4697     4697           
  Misses       1982     1982           
Flag Coverage Δ
unittests 70.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrea-pasquale andrea-pasquale merged commit c566eac into main Jul 18, 2024
37 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_compiler_str_qubits branch July 18, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants