-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor backends
: migrating pytorch
and creating jax
#12
Conversation
Just a guess but... I believe you did not receive any feedback on this PR, because you didn't ask anyone :P Btw, this is targeting https://github.com/qiboteam/qiboml/tree/expectation that has not even a PR... |
Ups :)
I changed the targeted branch into main since there are no conflicts anyway. |
Then you can just merge :)
It seems that it has already been merged in #9. Then, just delete the branch. |
@scarrazza is it possible to enable branch autodeletion? In this way the PRs will be retargeted automatically (now I realized: this was based on #9, and simply not updated after that one got merged). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
===========================================
- Coverage 29.67% 16.62% -13.05%
===========================================
Files 6 8 +2
Lines 246 439 +193
===========================================
Hits 73 73
- Misses 173 366 +193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@alecandido, done together with branch protection (main). |
@scarrazza maybe it does not apply to existing PRs? #19 In any case, if it's not already like that, can you make branch protection with single reviewer? |
Probably yes, it is already si already reviewer. |
No description provided.