Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backends: migrating pytorch and creating jax #12

Merged
merged 8 commits into from
May 17, 2024
Merged

Conversation

MatteoRobbiati
Copy link
Contributor

No description provided.

@alecandido
Copy link
Member

alecandido commented May 16, 2024

Just a guess but... I believe you did not receive any feedback on this PR, because you didn't ask anyone :P

Btw, this is targeting https://github.com/qiboteam/qiboml/tree/expectation that has not even a PR...
Since qiboml is experimental anyhow, to reduce the complexity of open PRs I'd just merge expectation into main, and then backends into main as well. We could keep improving their content in further PRs.

@MatteoRobbiati MatteoRobbiati changed the base branch from expectation to main May 17, 2024 06:43
@MatteoRobbiati
Copy link
Contributor Author

Just a guess but... I believe you did not receive any feedback on this PR, because you didn't ask anyone :P

Ups :)

Btw, this is targeting https://github.com/qiboteam/qiboml/tree/expectation that has not even a PR... Since qiboml is experimental anyhow, to reduce the complexity of open PRs I'd just merge expectation into main, and then backends into main as well. We could keep improving their content in further PRs.

I changed the targeted branch into main since there are no conflicts anyway.

@alecandido
Copy link
Member

alecandido commented May 17, 2024

I changed the targeted branch into main since there are no conflicts anyway.

Then you can just merge :)

(but please, merge also expectation, since the other PRs will work on top of that)

It seems that it has already been merged in #9. Then, just delete the branch.

@alecandido
Copy link
Member

alecandido commented May 17, 2024

@scarrazza is it possible to enable branch autodeletion?

image

In this way the PRs will be retargeted automatically (now I realized: this was based on #9, and simply not updated after that one got merged).

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 193 lines in your changes are missing coverage. Please review.

Project coverage is 16.62%. Comparing base (151f54e) to head (09e5d82).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #12       +/-   ##
===========================================
- Coverage   29.67%   16.62%   -13.05%     
===========================================
  Files           6        8        +2     
  Lines         246      439      +193     
===========================================
  Hits           73       73               
- Misses        173      366      +193     
Flag Coverage Δ
unittests 16.62% <0.00%> (-13.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qiboml/backends/jax.py 0.00% <0.00%> (ø)
src/qiboml/backends/pytorch.py 0.00% <0.00%> (ø)

@alecandido alecandido merged commit a9e7f9e into main May 17, 2024
9 of 11 checks passed
@scarrazza
Copy link
Member

@alecandido, done together with branch protection (main).

@alecandido
Copy link
Member

@scarrazza maybe it does not apply to existing PRs? #19
image

In any case, if it's not already like that, can you make branch protection with single reviewer?
Just for the time being, since the project is rather small (so it is experimental, and quickly iterating). However, it's just a temporary measure, not really top-priority anyhow.

@scarrazza
Copy link
Member

Probably yes, it is already si already reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants