Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimizers to qiboml #4

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add optimizers to qiboml #4

wants to merge 12 commits into from

Conversation

MatteoRobbiati
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati commented Mar 5, 2024

Since in Qibo the optimizers refactor is very slow (due to many older applications and examples based on the old interface), I would suggest to move the optimizers here, so that we can start integrating the automatic differentiation into the optimizers.

The first two steps I am figuring out are:

  1. integrating automatic diff with optimizers;
  2. add a compile method to the models, which set optimizer and loss_function, and then write a model.fit method on top of the optimizers structure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not yet a Pytest suite, but it could be a starting point. I'd suggest you to immediately place it in tests/ top-level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants