-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optimizers to qiboml
#4
Open
MatteoRobbiati
wants to merge
12
commits into
main
Choose a base branch
from
opt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoRobbiati
requested review from
alecandido,
BrunoLiegiBastonLiegi,
niccololaurora and
scarrazza
March 5, 2024 18:13
alecandido
reviewed
Mar 15, 2024
src/qiboml/test_reuploading.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not yet a Pytest suite, but it could be a starting point. I'd suggest you to immediately place it in tests/
top-level.
alecandido
reviewed
Mar 15, 2024
alecandido
reviewed
Mar 15, 2024
Thanks! Co-authored-by: Alessandro Candido <candido.ale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in Qibo the optimizers refactor is very slow (due to many older applications and examples based on the old interface), I would suggest to move the optimizers here, so that we can start integrating the automatic differentiation into the optimizers.
The first two steps I am figuring out are:
compile
method to the models, which setoptimizer
andloss_function
, and then write amodel.fit
method on top of the optimizers structure.