Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNIST binary classification tutorial #49

Merged
merged 6 commits into from
Nov 24, 2024
Merged

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

As per title.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi marked this pull request as ready for review November 19, 2024 19:09
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.59%. Comparing base (807c89b) to head (5b77072).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   66.59%   66.59%           
=======================================
  Files          11       11           
  Lines         488      488           
=======================================
  Hits          325      325           
  Misses        163      163           
Flag Coverage Δ
unittests 66.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@BrunoLiegiBastonLiegi
Copy link
Contributor Author

@MatteoRobbiati @niccololaurora can you double check that the notebook is clear?

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments:

  1. I would add subtitles, it will lighten the text (which is very clear but some blocks of text would benefit of subtitles);
  2. I would put as optional the installation of the packages (namely, comment the first cell or something equivalent);
  3. Add labels to $x$ and $y$ axis of loss function plot;
  4. Introduce the F1 score or link to some reference;
  5. not necessary - I would add the same image of the first code cell with the mnist digit and the new prediction. In the future I will write a function to plot e.g. 10 images with titles in red and green showing misclassification.

@BrunoLiegiBastonLiegi
Copy link
Contributor Author

Thanks, I should have addressed everything.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi merged commit 83331a3 into main Nov 24, 2024
26 checks passed
@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi deleted the tutorial_notebook branch November 24, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants