-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNIST binary classification tutorial #49
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 66.59% 66.59%
=======================================
Files 11 11
Lines 488 488
=======================================
Hits 325 325
Misses 163 163
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@MatteoRobbiati @niccololaurora can you double check that the notebook is clear? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments:
- I would add subtitles, it will lighten the text (which is very clear but some blocks of text would benefit of subtitles);
- I would put as optional the installation of the packages (namely, comment the first cell or something equivalent);
- Add labels to
$x$ and$y$ axis of loss function plot; - Introduce the F1 score or link to some reference;
- not necessary - I would add the same image of the first code cell with the mnist digit and the new prediction. In the future I will write a function to plot e.g. 10 images with titles in red and green showing misclassification.
Thanks, I should have addressed everything. |
As per title.