Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows #7

Merged
merged 19 commits into from
Mar 28, 2024
Merged

Workflows #7

merged 19 commits into from
Mar 28, 2024

Conversation

Edoardo-Pedicillo
Copy link
Contributor

This PR deploy the workflows

@Edoardo-Pedicillo
Copy link
Contributor Author

This PR is ready, but the linting is failing. @MatteoRobbiati could you please fix it?

Copy link

codecov bot commented Mar 20, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Edoardo-Pedicillo
Copy link
Contributor Author

I removed the pdbpp dependency, because it is not strictly related to tests and it cause the following error
https://github.com/qibogang/qiboml/actions/runs/8360680848/job/22887073306#step:11:49, it seems one of its dependency py3k_compat is not updated with py 3.10 changes related to Callable (see https://stackoverflow.com/questions/69515086/error-attributeerror-collections-has-no-attribute-callable-using-beautifu)

@Edoardo-Pedicillo
Copy link
Contributor Author

@MatteoRobbiati do you want me to add the workflows to generate the docs and publish the package, or is it too early?

@Edoardo-Pedicillo
Copy link
Contributor Author

After speaking with @alecandido, we agree it is better to take the pdbpp dependency and set the dependencies of the dev group optional.

@MatteoRobbiati
Copy link
Contributor

After speaking with @alecandido, we agree it is better to take the pdbpp dependency and set the dependencies of the dev group optional.

Fine with me.

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review March 28, 2024 10:48
@Edoardo-Pedicillo
Copy link
Contributor Author

Edoardo-Pedicillo commented Mar 28, 2024

@MatteoRobbiati this PR is ready, let me know how many approvals I need.
I opened #8 to implement the other workflows.

@MatteoRobbiati MatteoRobbiati merged commit a837159 into main Mar 28, 2024
11 checks passed
@MatteoRobbiati MatteoRobbiati deleted the workflows branch May 17, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants