Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Black maxline #97

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Change Black maxline #97

merged 1 commit into from
Dec 21, 2023

Conversation

rodolfocarobene
Copy link
Contributor

For some reason, I was using a max-line-length of 120 in the black pre-commit...
I removed it so now it's back to the default (100)

Checklist before merge:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Documentation is updated.

Sorry, something went wrong.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5d8d246) 93.97% compared to head (e900c74) 94.00%.

Files Patch % Lines
src/qibosoq/server.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   93.97%   94.00%   +0.02%     
==========================================
  Files          12       12              
  Lines         681      684       +3     
==========================================
+ Hits          640      643       +3     
  Misses         41       41              
Flag Coverage Δ
unittests 94.00% <95.65%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you just copied from Qibolab, I removed it only recently.

Better to just use the default, I agree :)

@rodolfocarobene rodolfocarobene merged commit e064f42 into main Dec 21, 2023
26 checks passed
@rodolfocarobene rodolfocarobene deleted the black branch December 23, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants