-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize package and content v2 #10
Conversation
alecandido
commented
Feb 7, 2023
•
edited
Loading
edited
- provide testing workflow
- adjust pylint and pytest basic configs
- drop unused deps
- split tests
- fix numba missing threads
- this now has a dedicated issue, and won't be addressed here Invalid NUMBA_NUM_THREADS while running with Numpy qibojit#107
@nitinshivaraman I'm adding you as a reviewer to make you aware of updates, but I will explicitly notify (at this point by removing draft mode, but also tagging you) when I'll be ready to merge. P.S.: in particular not before workflows will be passing |
@scarrazza can you provide a |
Workflows are now waiting on As soon as we get back the green tick, we can just merge and continue the review in #8 |
Done, please go ahead, thanks. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## qasm_with_quimb_backend #10 +/- ##
==========================================================
Coverage ? 37.91%
==========================================================
Files ? 3
Lines ? 182
Branches ? 0
==========================================================
Hits ? 69
Misses ? 113
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@scarrazza (it is just a single button, you get there through the link) |
@nitinshivaraman now that tests are passing, you can merge whenever you're happy with the content :) |
Please retry now (we have already 5/5 seats in codecov filled). |
I was actually not aware of this limitation... EDIT: I saw it on the page, it should be lifted by making more used repos public, so we usually don't hit this constraint... |
Exactly |
Thanks a lot @alecandido! I will proceed to merge it :) |