Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize package and content v2 #10

Merged
merged 9 commits into from
Feb 8, 2023
Merged

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Feb 7, 2023

@alecandido
Copy link
Member Author

alecandido commented Feb 7, 2023

@nitinshivaraman I'm adding you as a reviewer to make you aware of updates, but I will explicitly notify (at this point by removing draft mode, but also tagging you) when I'll be ready to merge.

P.S.: in particular not before workflows will be passing

@alecandido
Copy link
Member Author

@scarrazza can you provide a CODECOV_TOKEN in secrets? It is required by the shared workflow, but of course not available in this repo.

@alecandido
Copy link
Member Author

Workflows are now waiting on CODECOV_TOKEN, but they might be alright.

As soon as we get back the green tick, we can just merge and continue the review in #8

@alecandido alecandido marked this pull request as ready for review February 7, 2023 11:07
@scarrazza
Copy link
Member

@scarrazza can you provide a CODECOV_TOKEN in secrets? It is required by the shared workflow, but of course not available in this repo.

Done, please go ahead, thanks.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (qasm_with_quimb_backend@625e3ec). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             qasm_with_quimb_backend      #10   +/-   ##
==========================================================
  Coverage                           ?   37.91%           
==========================================================
  Files                              ?        3           
  Lines                              ?      182           
  Branches                           ?        0           
==========================================================
  Hits                               ?       69           
  Misses                             ?      113           
  Partials                           ?        0           
Flag Coverage Δ
unittests 37.91% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alecandido
Copy link
Member Author

The author of this PR, AleCandido, is not an activated member of this organization on Codecov. Please activate this user on Codecov to display this PR comment. Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations. Please don't hesitate to email us at support@codecov.io with any questions.

@scarrazza (it is just a single button, you get there through the link)

@alecandido
Copy link
Member Author

@nitinshivaraman now that tests are passing, you can merge whenever you're happy with the content :)

@scarrazza
Copy link
Member

Please retry now (we have already 5/5 seats in codecov filled).

@alecandido
Copy link
Member Author

alecandido commented Feb 7, 2023

Please retry now (we have already 5/5 seats in codecov filled).

I was actually not aware of this limitation...

EDIT: I saw it on the page, it should be lifted by making more used repos public, so we usually don't hit this constraint...

@scarrazza
Copy link
Member

EDIT: I saw it on the page, it should be lifted by making more used repos public, so we usually don't hit this constraint...

Exactly

@nitinshivaraman
Copy link
Contributor

@nitinshivaraman now that tests are passing, you can merge whenever you're happy with the content :)

Thanks a lot @alecandido! I will proceed to merge it :)

@nitinshivaraman nitinshivaraman merged commit 196a1bb into qasm_with_quimb_backend Feb 8, 2023
@alecandido alecandido deleted the pypkg branch February 8, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants