Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Poetry #26

Merged
merged 14 commits into from
Feb 16, 2024
Merged

Add Poetry #26

merged 14 commits into from
Feb 16, 2024

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Feb 8, 2024

Close #23

@yjmaxpayne at the end, I needed it for something else, so I already defined the Poetry configuration.

I still have to check that everything is alright, and that it fully replaces setup.py.

Copy link

@yjmaxpayne yjmaxpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alessandro, thanks a lot for implementing this. I noticed missing dependencies on Qibo and Qibojit. Please add them in to ensure at least the tests/test_quimb_backend.py can pass.

pyproject.toml Show resolved Hide resolved
@alecandido alecandido requested a review from yjmaxpayne February 9, 2024 02:09
Copy link

@yjmaxpayne yjmaxpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the revisions.

@scarrazza scarrazza added this to the QiboTN 0.0.1 milestone Feb 16, 2024
@scarrazza
Copy link
Member

@alecandido thanks for this, could you please fix the conflict so we can merge?

Since redundant with the corresponding extra, that is the appropriate space for it
@alecandido alecandido marked this pull request as ready for review February 16, 2024 07:03
@alecandido alecandido requested a review from scarrazza February 16, 2024 07:03
@scarrazza
Copy link
Member

It looks like cannot find qibo 0.2.4.

@alecandido
Copy link
Member Author

alecandido commented Feb 16, 2024

I updated the lock file, but I had no problem in installing.

Could you please provide the error log?

Poetry is not using pip any longer, but it's using the same install library used by pip, and for me it is able to resolve.

iPython 3.11.7 (main, Dec  4 2023, 18:10:11) [Clang 16.0.6 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 7.34.0 -- An enhanced Interactive Python. Type '?' for help.

[ins] In [1]: import qibo

[ins] In [2]: qibo.__version__
Out[2]: '0.2.4'

@scarrazza
Copy link
Member

scarrazza commented Feb 16, 2024

From the build I see

ERROR: Could not find a version that satisfies the requirement qibo<0.3.0,>=0.2.4 (from qibotn) (from versions: 0.0.1b3, 0.0.1b4, 0.0.1b5, 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.4, 0.1.5, 0.1.6rc0, 0.1.6rc1, 0.1.6, 0.1.7rc0, 0.1.7rc1, 0.1.7, 0.1.8rc0, 0.1.8, 0.1.9, 0.1.10, 0.1.11, 0.1.12, 0.1.13, 0.1.14, 0.1.15, 0.1.16, 0.2.0, 0.2.1, 0.2.2)
ERROR: No matching distribution found for qibo<0.3.0,>=0.2.4

https://github.com/qiboteam/qibotn/actions/runs/7927631670/job/21644355872?pr=26#step:4:113

@alecandido
Copy link
Member Author

That workflow is largely outdated, however, I tried to reproduce the steps locally, and I could not (to me it also installs correctly with pip, and the steps written there).

I'm trying to update the workflow (I don't want to use yet the reusable ones, because we still have to decide how to address #28).

@alecandido
Copy link
Member Author

My bad: it was already using the reusable ones. Since we're already there I just moved to the Poetry version (the one we use in all the other repos), and keep debugging with that one.

@alecandido
Copy link
Member Author

@scarrazza: ok, now it is failing because of the dependencies, but this is because of #29.

I'd say it is now out of the scope of this PR.

@scarrazza
Copy link
Member

Ok, shall we merge?

@alecandido alecandido merged commit 2058976 into qibotn_integration Feb 16, 2024
1 of 5 checks passed
@alecandido alecandido deleted the poetry branch February 16, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Transition from setup.py to Poetry for Better Package and Dependency Management
3 participants