-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Poetry #26
Add Poetry #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alessandro, thanks a lot for implementing this. I noticed missing dependencies on Qibo and Qibojit. Please add them in to ensure at least the tests/test_quimb_backend.py
can pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the revisions.
@alecandido thanks for this, could you please fix the conflict so we can merge? |
Since redundant with the corresponding extra, that is the appropriate space for it
It looks like cannot find qibo 0.2.4. |
I updated the lock file, but I had no problem in installing. Could you please provide the error log? Poetry is not using iPython 3.11.7 (main, Dec 4 2023, 18:10:11) [Clang 16.0.6 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 7.34.0 -- An enhanced Interactive Python. Type '?' for help.
[ins] In [1]: import qibo
[ins] In [2]: qibo.__version__
Out[2]: '0.2.4' |
From the build I see
https://github.com/qiboteam/qibotn/actions/runs/7927631670/job/21644355872?pr=26#step:4:113 |
That workflow is largely outdated, however, I tried to reproduce the steps locally, and I could not (to me it also installs correctly with I'm trying to update the workflow (I don't want to use yet the reusable ones, because we still have to decide how to address #28). |
My bad: it was already using the reusable ones. Since we're already there I just moved to the Poetry version (the one we use in all the other repos), and keep debugging with that one. |
To be compliant with the Poetry version
@scarrazza: ok, now it is failing because of the dependencies, but this is because of #29. I'd say it is now out of the scope of this PR. |
Ok, shall we merge? |
Close #23
@yjmaxpayne at the end, I needed it for something else, so I already defined the Poetry configuration.
I still have to check that everything is alright, and that it fully replaces
setup.py
.