Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the version info into __init__.py #6

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Move the version info into __init__.py #6

merged 2 commits into from
Jul 14, 2022

Conversation

liweintu
Copy link
Contributor

This PR addresses issue #5 by moving the version info into the init.py of the package. Any comments for merging? @scarrazza , @nitinshivaraman

nitinshivaraman
nitinshivaraman approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@nitinshivaraman nitinshivaraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to retrieve version number with the new changes. Approved.

@scarrazza
Copy link
Member

Thanks, could you please update the version in the __init__.py with 0.0.1.dev0 instead of 0.1.

@liweintu
Copy link
Contributor Author

Thanks, could you please update the version in the __init__.py with 0.0.1.dev0 instead of 0.1.

Yes, the version has been changed to 0.0.1.dev0 in this new commit: 05c1c4f

@liweintu
Copy link
Contributor Author

Hi @scarrazza May I know which merging option below is preferred? Thanks.
image

@scarrazza
Copy link
Member

The first one should be fine.

@liweintu
Copy link
Contributor Author

The first one should be fine.

Got it. Choosing the first option and merging.

@liweintu liweintu merged commit d6aafa3 into main Jul 14, 2022
@liweintu liweintu mentioned this pull request Jul 15, 2022
Closed
@alecandido alecandido deleted the refactor_version_info branch February 16, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scarrazza scarrazza scarrazza approved these changes

@nitinshivaraman nitinshivaraman nitinshivaraman approved these changes

@stavros11 stavros11 Awaiting requested review from stavros11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liweintu @scarrazza @nitinshivaraman